Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pull js stack trace from wrapped NativeScriptExceptions #1774

Merged
merged 2 commits into from
Jul 26, 2023
Merged

fix: pull js stack trace from wrapped NativeScriptExceptions #1774

merged 2 commits into from
Jul 26, 2023

Conversation

rigor789
Copy link
Member

@rigor789 rigor789 commented Jul 12, 2023 •
edited
Loading

Unwrap and print stack traces from RuntimeException that are caused by a NativeScriptException.
This now properly shows the JS stack trace in the exception for easier debugging.

Before:
image

After:
image

This should greatly help debug errors like these:

@cla-bot cla-bot bot added the cla: yes label Jul 12, 2023
@rigor789
Copy link
Member Author

Example of terminal output from throwing a dummy exception in the activity callbacks:
(left is current, right is with this PR)

image

@rigor789 rigor789 merged commit 52b7fa2 into main Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edusperoni edusperoni edusperoni approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rigor789 @edusperoni